feat(agent): configure PostHog exec permissions#3578
Merged
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(agent): configure PostHog exec perm..." | Re-trigger Greptile |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
![veria-ai[bot]](https://avatars.githubusercontent.com/in/1723776?s=60&v=4){kind=small}
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 5 · PR risk: 0/10 |
tatoalo
approved these changes
Jul 20, 2026
skoob13
force-pushed
the
feat/configurable-posthog-exec-permissions
branch
from
July 20, 2026 14:13
473168f to
98d2308
Compare
skoob13
force-pushed
the
feat/configurable-posthog-exec-permissions
branch
from
July 20, 2026 14:23
98d2308 to
bdf0d87
Compare
Review fixes for the configurable exec-permission feature: restore the needs_approval check ahead of the Claude exec gate so an explicit ask-me setting can't be bypassed by remembered approvals or hands-off modes; validate _meta.posthogExecPermissionRegex through the shared Zod schema in both adapters, warning and falling back to the default instead of crashing or silently flipping gating; filter Codex exec sub-tools in the adapter's approval handlers so local sessions only prompt for matching destructive calls (with Claude-parity hands-off in auto/full-access); make toCodexMcpServers take an honest gatePosthogExec flag; return a discriminated result from resolvePermission with distinct errors for unknown requests vs unoffered options; exempt question responses (synthetic option_<idx> ids) from the offered-option check, which was hanging cloud question relays; parse exec input via Zod; document the posthog server-name contract; unwrap README prose. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
skoob13
enabled auto-merge (squash)
July 21, 2026 10:16
skoob13
disabled auto-merge
July 21, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interactive cloud runs could bypass PostHog MCP exec approvals in hands-off permission presets, while the gated sub-tools were hardcoded and Claude-specific.
Changes
(^|-)(partial-update|update|patch|delete|destroy)(-|$)--posthogExecPermissionRegexgetEffectiveModeto relay or buffer interactive approvals and auto-approve background runsautoandbypassPermissionssessionsHow did you test this code?
@posthog/weberrors from missing@posthog/quillexports;@posthog/agenttypecheck passesPublish to changelog?
Do not publish to changelog.